[Mesa-dev] [PATCH 2/2] glsl: Add pragma to disable all warnings
Matt Turner
mattst88 at gmail.com
Mon Nov 5 21:15:14 UTC 2018
On Thu, Nov 1, 2018 at 3:37 PM Ian Romanick <idr at freedesktop.org> wrote:
>
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> warnings. This is a big hammer. If we ever need a smaller hammer, we
I bet there was a line in the commit message before this that started
with '#pragma', which git commit interpreted as a comment.
> can enhance this functionality.
>
> There is one lame thing about this. Because we parse everything, create
> an AST, then convert the AST to GLSL IR, we have to treat the #pragma
> like a statment. This means that you can't do something like
>
> void
> __foo
> (float param0);
Maybe here too?
Otherwise, looks great to me.
Reviewed-by: Matt Turner <mattst88 at gmail.com>
More information about the mesa-dev
mailing list