[Mesa-dev] [PATCH] gallium/tests/trivial, meson build: Add dep_thread to build dependencies

Dylan Baker dylan at pnwbakers.com
Tue Nov 20 17:07:11 UTC 2018


Quoting Gert Wollny (2018-11-20 03:50:35)
> From: Gert Wollny <gert.wollny at collabora.com>
> 
> When moving the CPU tests to src/util the needed bits were no longer pulled
> here in when doing debug builds resulting in
> 
> g++  -o src/gallium/tests/trivial/quad-tex  ...
> 
> src/util/libmesa_util.a(u_cpu_detect.c.o): In function `call_once':
> ../include/c11/threads_posix.h:96: undefined reference to `pthread_once'
> collect2: error: ld returned 1 exit status
> 
> Solve this by adding dep_thread to the build dependencies for the test.
> 
> Fixes: b02bd3d1cbfdacabc6403f2da7b5d0a9aa527e6
>    util: move u_cpu_detect to util
> Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> ---
>  src/gallium/tests/trivial/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/tests/trivial/meson.build b/src/gallium/tests/trivial/meson.build
> index bbb25519e1..6f66ac54c0 100644
> --- a/src/gallium/tests/trivial/meson.build
> +++ b/src/gallium/tests/trivial/meson.build
> @@ -24,6 +24,7 @@ foreach t : ['compute', 'tri', 'quad-tex']
>      '@0 at .c'.format(t),
>      include_directories : inc_common,
>      link_with : [libmesa_util, libgallium, libpipe_loader_dynamic],
> +    dependencies : [dep_thread],
>      install : false,
>    )
>  endforeach
> -- 
> 2.18.1
> 

I can't reproduce this in any configuration I can come up with, what's your
meson configuration line?

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181120/9bbc1888/attachment.sig>


More information about the mesa-dev mailing list