[Mesa-dev] [PATCH 04/11] st/mesa: Use Array._DrawVAO in st_atom_array.c.

[Erik Faye-Lund]

On Mon, 2018-11-26 at 21:33 +0100, Mathias Fröhlich wrote:
> Hi,
> 
> On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote:
> > I know this is *very* late notice, but this commit broke Super Tux
> > Kart
> > on VirGL. Both the player-models as as well as the level data
> > renders
> > with gibberish vertex positions since this commit.
> > 
> > The fix that Rob Clark did on top does not fix the problem (and
> > shouldn't have; VirGL doesn't use NIR).
> 
> Do you have any idea how I can reproduce that issue with the least
> effort?
> 
> Can you tell me what the virgl driver sees at
> Const.MaxVertexAttribRelativeOffset and
> Const.MaxVertexAttribStride?
> 
> best
> Mathias
> 

This depends a bit on the version in question. Nothing seems to ever
set Const.MaxVertexAttribRelativeOffset away from its initial value of
2047... Directly on top of your commit, Const.MaxVertexAttribStride is
reported as zero. On master, it's reported as whatever the host
supports, which is 2048 in my case.