[Mesa-dev] [PATCH 6/6] nir: Release per-block metadata in nir_sweep

[Jason Ekstrand]

Rb for this patch

On November 27, 2018 18:39:25 "Ian Romanick" <idr at freedesktop.org> wrote:

> From: Ian Romanick <ian.d.romanick at intel.com>
>
> nir_sweep already marks all metadata invalid, so it is safe to release
> the memory here too.
>
> mean soft fp64 using uint64:   1,342,759,331 => 1,010,670,475
> gfxbench5 aztec ruins high 11:    63,555,571 =>    61,889,811
> deus ex mankind divided 148:      62,845,304 =>    62,829,640
> deus ex mankind divided 2890:     71,922,686 =>    71,922,686
> dirt showdown 676:                69,238,607 =>    69,238,607
> dolphin ubershaders 210:          77,822,072 =>    77,822,072
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
> src/compiler/nir/nir_sweep.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/compiler/nir/nir_sweep.c b/src/compiler/nir/nir_sweep.c
> index aab641388db..b6b56aa078c 100644
> --- a/src/compiler/nir/nir_sweep.c
> +++ b/src/compiler/nir/nir_sweep.c
> @@ -63,6 +63,15 @@ sweep_block(nir_shader *nir, nir_block *block)
> {
>    ralloc_steal(nir, block);
>
> +   /* sweep_impl will mark all metadata invalid.  We can safely release all of
> +    * this here.
> +    */
> +   ralloc_free(block->live_in);
> +   block->live_in = NULL;
> +
> +   ralloc_free(block->live_out);
> +   block->live_out = NULL;
> +
>    nir_foreach_instr(instr, block) {
>       ralloc_steal(nir, instr);
>
> --
> 2.14.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev