[Mesa-dev] [PATCH] docs: Document optional GitLab code review process

Jason Ekstrand jason at jlekstrand.net
Thu Nov 29 18:02:57 UTC 2018


On Thu, Nov 29, 2018 at 11:37 AM Matt Turner <mattst88 at gmail.com> wrote:

> On Wed, Nov 28, 2018 at 11:30 AM Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > We have enough stubborn people on the list that MRs are going to
> constantly get pulled back to the list just because someone doesn't want to
> use the web interface.
>
> A couple of people in this thread have now made similar claims, but
> thus far no one has spoken out against MR-based review.
>

If no one minds MR-based review then let's just do it?

I think the point is that the only reason to have the weird hybrid is to
satisfy the people that are against MR-based review.  If those people
exist, then the above problem is real and the hybrid is going to cause
problems.  If they do not exist, then the weird hybrid is pointless.
Therefore (please pardon the formal logic), the MR+list hybrid is a bad
idea regardless of whether or not MR haters exist.

Of course not every contributor has offered an opinion, but I'm not
> sure the claim is still valid.
>

Fair enough.  I was honestly expecting to see way more push-back.  I'm a
bit surprised that the most extreme position expressed so far is Jordan's,
"maybe not so fast".

--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181129/aa2afe11/attachment.html>


More information about the mesa-dev mailing list