[Mesa-dev] [PATCH v2 00/29] do not allow invalid texture-format enums

[Francesco Ansanelli]

Il giorno ven 30 nov 2018, 12:26 Erik Faye-Lund <
erik.faye-lund at collabora.com> ha scritto:

> On Fri, 2018-11-23 at 11:53 +0100, Erik Faye-Lund wrote:
> > OK, so here's a v2 of this series. These are the changes since v1:
> > - Removed double-semicolons in patch #25
> > - Removed default-case and questionable comment in patch #25
> > - Dropped patch #30, as it would regress functionality on two drivers
> >
> > Please review :)
>
> Ping? Any takers?
>
I read all the patches and didn't spot anything wrong, but please don't
consider this a proper review.

>
> > Erik Faye-Lund (29):
> >   mesa/main: make _mesa_has_tessellation return bool
> >   mesa/main: rename format-check function
> >   mesa/main: clean up S3_s3tc check
> >   mesa/main: clean up OES_texture_float_linear check
> >   mesa/main: clean up ES2_compatibility check
> >   mesa/main: clean up integer texture check
> >   mesa/main: use _mesa_has_FOO_bar for compressed format checks
> >   mesa/main: do not allow s3tc enums on gles1
> >   mesa/main: do not allow etc2 enums on gles1
> >   mesa/main: do not allow astc enums on gles1
> >   mesa/main: do not allow depth-texture enums on gles1
> >   mesa/main: do not allow stencil-texture enums on gles1
> >   mesa/main: do not allow ARB_texture_rgb10_a2ui enums before gles3
> >   mesa/main: do not allow integer-texture enums before gles3
> >   mesa/main: do not allow ARB_depth_buffer_float enums before gles3
> >   mesa/main: do not allow EXT_packed_float enums before gles3
> >   mesa/main: do not allow rg-textures enums before gles3
> >   mesa/main: do not allow EXT_texture_shared_exponent enums before
> > gles3
> >   mesa/main: do not allow MESA_ycbcr_texture enums on gles
> >   mesa/main: do not allow type_2_10_10_10_REV enums before gles3
> >   mesa/main: do not allow floating-point texture enums on gles1
> >   mesa/main: do not allow snorm-texture enums before gles3
> >   mesa/main: do not allow sRGB texture enums before gles3
> >   mesa/main: do not allow EXT_texture_sRGB_R8 enums before gles3
> >   mesa/main: split float-texture support checking in two
> >   mesa/main: require EXT_texture_type_2_10_10_10_REV for gles3
> >   mesa/main: require EXT_texture_sRGB for gles3
> >   mesa/st: do not probe for the same texture-formats twice
> >   mesa/main: do not require float-texture filtering for es3
> >
> >  src/mesa/main/context.h                |  59 ++++++-
> >  src/mesa/main/glformats.c              | 221 +++++++++++++--------
> > ----
> >  src/mesa/main/glformats.h              |   6 +-
> >  src/mesa/main/teximage.c               |   4 +-
> >  src/mesa/main/version.c                |   8 +-
> >  src/mesa/state_tracker/st_extensions.c |   8 +-
> >  6 files changed, 184 insertions(+), 122 deletions(-)
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181130/8c5866bc/attachment.html>