[Mesa-dev] [Bug 108120] tools_error2aub-error2aub fails to build: error: implicit declaration of function ‘va_start’
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Tue Oct 2 10:00:09 UTC 2018
https://bugs.freedesktop.org/show_bug.cgi?id=108120
--- Comment #4 from Lionel Landwerlin <lionel.g.landwerlin at linux.intel.com> ---
(In reply to Paul Menzel from comment #3)
> (In reply to Lionel Landwerlin from comment #2)
> > Sent https://patchwork.freedesktop.org/patch/254342/
>
> Thanks, I just wanted to upload the same change. Two nitpicks.
>
> 1. Should the include be inserted lexicographically?
> 2. I always prefer to have the error message in the commit message.
>
> PS: I am not very involved in Mesa, but isn’t there a build tester, which
> should have caught that error? (Also, why did nobody else get it?)
Feel free to upload a better change, I'll review and push to master.
There are build testers. Not quite sure why it wasn't caught...
The only explanation I could think of is that we have different build option
(we usually build a large set of drivers, not just intel ones) and that somehow
pulls in a header file already including stdarg.h.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181002/087588af/attachment.html>
More information about the mesa-dev
mailing list