[Mesa-dev] [PATCH 1/5] glspirv: drop pointless assert (size_t is unsigned)
Alejandro Piñeiro
apinheiro at igalia.com
Fri Oct 5 13:53:59 UTC 2018
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
On 05/10/18 02:00, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Found by coverity
> ---
> src/mesa/main/glspirv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/mesa/main/glspirv.c b/src/mesa/main/glspirv.c
> index fecf7384eb3..972989055e9 100644
> --- a/src/mesa/main/glspirv.c
> +++ b/src/mesa/main/glspirv.c
> @@ -73,8 +73,6 @@ _mesa_spirv_shader_binary(struct gl_context *ctx,
> struct gl_spirv_module *module;
> struct gl_shader_spirv_data *spirv_data;
>
> - assert(length >= 0);
> -
> module = malloc(sizeof(*module) + length);
> if (!module) {
> _mesa_error(ctx, GL_OUT_OF_MEMORY, "glShaderBinary");
More information about the mesa-dev
mailing list