[Mesa-dev] [PATCH 5/5] anv: add missing unlock in error path.

[Jason Ekstrand]

On Wed, Oct 10, 2018 at 9:47 AM Lionel Landwerlin <
lionel.g.landwerlin at intel.com> wrote:

> Oh dear...
>
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>
> Eric, Jason : Could it be the wsi CTS test you've seen locking up forever?
>

I don't think so.  It blocks in a different place.  In any case, good catch!

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


> On 05/10/2018 01:00, Dave Airlie wrote:
> > From: Dave Airlie <airlied at redhat.com>
> >
> > Not going to matter, but be consistent.
> >
> > Found by coverity
> > ---
> >   src/intel/vulkan/anv_allocator.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/src/intel/vulkan/anv_allocator.c
> b/src/intel/vulkan/anv_allocator.c
> > index f62d48ae3fe..67f2f73aa11 100644
> > --- a/src/intel/vulkan/anv_allocator.c
> > +++ b/src/intel/vulkan/anv_allocator.c
> > @@ -1358,6 +1358,7 @@ anv_bo_cache_import(struct anv_device *device,
> >         if ((new_flags & EXEC_OBJECT_PINNED) &&
> >             (bo->bo.flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) !=
> >             (bo_flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS)) {
> > +         pthread_mutex_unlock(&cache->mutex);
> >            return vk_errorf(device->instance, NULL,
> >                             VK_ERROR_INVALID_EXTERNAL_HANDLE,
> >                             "The same BO was imported on two different
> heaps");
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181010/eef27bfd/attachment.html>