[Mesa-dev] [PATCH 2/2] glx: be explicit about when mapping X <> GLX visuals

Ian Romanick idr at freedesktop.org
Sat Oct 6 00:45:12 UTC 2018


Series is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 10/03/2018 06:12 AM, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Write down both X and GLX visual types when mapping from one to the
> other. Makes grepping through the code a tiny bit easier.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/glx/glxext.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/glx/glxext.c b/src/glx/glxext.c
> index ca3bf9d027f..cef81920356 100644
> --- a/src/glx/glxext.c
> +++ b/src/glx/glxext.c
> @@ -343,9 +343,12 @@ static GLint
>  convert_from_x_visual_type(int visualType)
>  {
>     static const int glx_visual_types[] = {
> -      GLX_STATIC_GRAY, GLX_GRAY_SCALE,
> -      GLX_STATIC_COLOR, GLX_PSEUDO_COLOR,
> -      GLX_TRUE_COLOR, GLX_DIRECT_COLOR
> +      [StaticGray]  = GLX_STATIC_GRAY,
> +      [GrayScale]   = GLX_GRAY_SCALE,
> +      [StaticColor] = GLX_STATIC_COLOR,
> +      [PseudoColor] = GLX_PSEUDO_COLOR,
> +      [TrueColor]   = GLX_TRUE_COLOR,
> +      [DirectColor] = GLX_DIRECT_COLOR,
>     };
>  
>     if (visualType < ARRAY_SIZE(glx_visual_types))
> 



More information about the mesa-dev mailing list