[Mesa-dev] [PATCH 1/3] anv: Add a dummy implementation of GetPhysicalDevicePresentRectanglesKHR

[Jason Ekstrand]

And what size would that be on Wayland?  I've opened a spec bug about this
and we'll talk about it on the SI call this week.  This entrypoint seems
extraordinarily half-baked to me.  I don't see how it makes any sense
outside of VK_KHR_display or windows full-screen exclusive.

--Jason

On Mon, Oct 15, 2018 at 10:21 AM Lionel Landwerlin <
lionel.g.landwerlin at intel.com> wrote:

> Argh :(
>
> Shouldn't we at least return the size of the surface?
>
> On 15/10/2018 16:08, Jason Ekstrand wrote:
>
> It's explicitly for a multi-device case where each device presents to part
> of the screen.  Since we don't do that, I'm not sure what we're supposed to
> do.
>
> On Mon, Oct 15, 2018 at 9:14 AM Lionel Landwerlin <
> lionel.g.landwerlin at intel.com> wrote:
>
>> I'm guessing we should plugged that into the number of screen on bare
>> DRM for example, which each screen native size reported in pRects.
>>
>> On 15/10/2018 04:47, Jason Ekstrand wrote:
>> > Not really sure what we're supposed to do with this one but we should do
>> > something.
>> > ---
>> >   src/intel/vulkan/anv_wsi.c | 11 +++++++++++
>> >   1 file changed, 11 insertions(+)
>> >
>> > diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c
>> > index 5ed1d711689..4f3f3fc57af 100644
>> > --- a/src/intel/vulkan/anv_wsi.c
>> > +++ b/src/intel/vulkan/anv_wsi.c
>> > @@ -294,3 +294,14 @@ VkResult anv_GetDeviceGroupSurfacePresentModesKHR(
>> >
>> >      return VK_SUCCESS;
>> >   }
>> > +
>> > +VkResult anv_GetPhysicalDevicePresentRectanglesKHR(
>> > +    VkPhysicalDevice                            physicalDevice,
>> > +    VkSurfaceKHR                                surface,
>> > +    uint32_t*                                   pRectCount,
>> > +    VkRect2D*                                   pRects)
>> > +{
>> > +   /* TODO: What should I be doing here? */
>> > +   *pRectCount = 0;
>> > +   return VK_SUCCESS;
>> > +}
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181015/b4d2966c/attachment.html>