[Mesa-dev] [PATCH 2/3] ac: Fix loading a dvec3 from an SSBO

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Thu, Oct 18, 2018 at 10:13 AM Connor Abbott <cwabbott0 at gmail.com> wrote:

> The comment was wrong, since the loop above casts to a type with the
> correct bitsize already.
>
> Fixes: 7e7ee82698247d8f93fe37775b99f4838b0247dd ("ac: add support for
> 16bit buffer loads")
> ---
>  src/amd/common/ac_nir_to_llvm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c
> b/src/amd/common/ac_nir_to_llvm.c
> index 402cf2d6655..ee75e2890dd 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -1685,8 +1685,8 @@ static LLVMValueRef visit_load_buffer(struct
> ac_nir_context *ctx,
>                 };
>
>                 if (num_bytes > 16 && num_components == 3) {
> -                       /* we end up with a v4f32 and v2f32 but shuffle
> fails on that */
> -                       results[1] = ac_build_expand_to_vec4(&ctx->ac,
> results[1], 2);
> +                       /* we end up with a v2i64 and i64 but shuffle
> fails on that */
> +                       results[1] = ac_build_expand(&ctx->ac, results[1],
> 1, 2);
>                 }
>
>                 LLVMValueRef swizzle = LLVMConstVector(masks,
> num_components);
> --
> 2.17.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181019/07278885/attachment.html>