[Mesa-dev] [Bug 108611] [radv] [regression, bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Oct 31 13:55:59 UTC 2018


Samuel Pitoiset <samuel.pitoiset at gmail.com> changed:

           What    |Removed                     |Added
            Summary|radv: LLVM 8.0 breaks       |[radv]
                   |lighting in Mass Effect     |[regression,bisected]: LLVM
                   |Andromeda                   |8.0 breaks lighting in Mass
                   |                            |Effect Andromeda

--- Comment #3 from Samuel Pitoiset <samuel.pitoiset at gmail.com> ---
Introduced by the following LLVM commit:

cc436fd26637b0629b95fd8e60fde61cec4b421f is the first bad commit
commit cc436fd26637b0629b95fd8e60fde61cec4b421f
Author: Nicolai Haehnle <nhaehnle at gmail.com>
Date:   Wed Oct 17 15:37:30 2018 +0000

    AMDGPU: Divergence-driven selection of scalar buffer load intrinsics

    Moving SMRD to VMEM in SIFixSGPRCopies is rather bad for performance if
    the load is really uniform. So select the scalar load intrinsics directly
    to either VMEM or SMRD buffer loads based on divergence analysis.

    If an offset happens to end up in a VGPR -- either because a floating
    point calculation was involved, or due to other remaining deficiencies
    in SIFixSGPRCopies -- we use v_readfirstlane.

    There is some unrelated churn in tests since we now select MUBUF offsets
    in a unified way with non-scalar buffer loads.

    Change-Id: I170e6816323beb1348677b358c9d380865cd1a19

    Reviewers: arsenm, alex-t, rampitec, tpr

    Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, t-tye,

    Differential Revision: https://reviews.llvm.org/D53283

    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@344696

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181031/554a7b6c/attachment-0001.html>

More information about the mesa-dev mailing list