[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Oct 31 14:15:38 UTC 2018


Samuel Pitoiset <samuel.pitoiset at gmail.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #23 from Samuel Pitoiset <samuel.pitoiset at gmail.com> ---
This is now fixed! Thanks to Christian and Nicolai!

commit 91533e99d40c335134a635deaee79c726bb618f0
Author: Nicolai Haehnle <nhaehnle at gmail.com>
Date:   Wed Oct 31 13:26:48 2018 +0000

    AMDGPU: Remove PHI loop condition optimization

    The optimization to early break out of loops if all threads are dead was
    never fully implemented.

    But the PHI node analyzing is actually causing a number of problems, so
    remove all the extra code for it.

    (This does actually regress code quality in a few places because it
     ends up relying more heavily on phi's of i1, which we don't do a
     great job with. However, since it fixes real bugs in the wild, we
     should take this change. I have some prototype changes to improve
     i1 lowering in general -- not just for control flow -- which should
     help recover the code quality, I just need to make those changes
     fit for general consumption. -- Nicolai)

    Change-Id: I6fc6c6c8961857ac6009fcfb9f7e5e48dc23fbb1
    Patch-by: Christian K├Ânig <christian.koenig at amd.com>

    Reviewers: arsenm, rampitec, tpr

    Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, t-tye,

    Differential Revision: https://reviews.llvm.org/D53359

    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@345718

You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181031/c6a52de1/attachment.html>

More information about the mesa-dev mailing list