[Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

[Jan Vesely]

On Wed, 2018-10-31 at 16:14 -0700, Dylan Baker wrote:
> Quoting Jan Vesely (2018-10-31 11:37:19)
> > On Wed, 2018-10-31 at 11:22 -0700, Francisco Jerez wrote:
> > > I don't object removing the pre-LLVM 5.0 paths, nor keeping them around
> > > in order to make r600 happy.  What would it take to forward-port the
> > > r600 image support code to more recent LLVM versions?
> > 
> > Converting the llvm pass to the new style of metadata passing and
> > updating libclc builtins.
> > There are things higher on my priority list wrt clover/libclc (fixing
> > rounding routines,
> > 
> > replacing the build system,
> 
> Do you have a build system in mind? I started doing a meson port for wrap
> purposes at one point, I could push it somewhere public if that interests you.

Thanks, but as an LLVM project I think cmake would be a better fit. I'm
still not sure what the place of libclc will be after LLVM converts to
git mono repo.

Jan

> 
> > adding support for
> > buffer sharing between devices). it will take some time unless someone
> > else volunteers.
> > 
> > Jan
> > 
> > > Jan Vesely <jan.vesely at rutgers.edu> writes:
> > > 
> > > > On Wed, 2018-10-31 at 17:02 +0000, Emil Velikov wrote:
> > > > > On Wed, 31 Oct 2018 at 15:57, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> > > > > > On Wed, 2018-10-31 at 13:30 +0000, Emil Velikov wrote:
> > > > > > > From: Emil Velikov <emil.velikov at collabora.com>
> > > > > > > 
> > > > > > > LLVM versions earlier than 5.0.1 are no longer supported.
> > > > > > 
> > > > > > I'd prefer to keep llvm-3.9, since it's the last version that supports
> > > > > > images for r600, but I'd leave the final decision to Francisco.
> > > > > > 
> > > > > Was it just image support that was dropped or all of r600?
> > > > > I take it there's not enough interest/manpower to address that?
> > > > > 
> > > > > I'm curious how are you building/managing things:
> > > > >  - full build with LLVM 3.9
> > > > >  - r600 build with LLVM 3.9, and another for $other component using newer LLVM
> > > > >  - other
> > > > 
> > > > I build only clover+r600, mostly to occasionally check that libclc
> > > > still works as expected. I don't expect mixing of LLVM versions to work
> > > > (although with versioned symbols it should).
> > > > I can always fall back to older mesa release for this, but building
> > > > from one source is nice, feel free to go ahead with Francisco's ack.
> > > > 
> > > > Jan
> > > > 
> > > > > If really needed, we could keep 3.9 solely for r600 and use 5.0.1+ elsewhere.
> > > > > Considering LLVM 3.9 isn't getting new updates with last one being in
> > > > > Sep 2016 we are seriously clinging to straws.
> > > > > 
> > > > > Thanks
> > > > > Emil
> > > > 
> > > > -- 
> > > > Jan Vesely <jan.vesely at rutgers.edu>
> > 
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181031/9ddd029c/attachment.sig>