[Mesa-dev] Meson windows v5 (10/19/2018) review

[Dylan Baker]

Quoting Liviu Prodea (2018-10-31 01:50:25)
> --default_library=static indeed solves the zlib and expat dependency so I
> tweaked my build script to do just that, As for the LLVM linking problems I
> think I finally understand what's going on. llvm-wrap option always links LLVM
> dynamically and ignores or it is incompatible with -Dshared-llvm=false.

Right, llvm-wrap says "I have a subproject called whatever, use the `dep_llvm`
from that. It doesn't know whether that's static or shared. If you build a
shared LLVM and point to shared you'll get shared, if you build a static LLVm
you'll get static linking. It's pretty much a "you get to keep the pieces"
king of deal.

> llvm-wrap could be coerced into supporting CRT override in Meson <= 0.47.2
> using c_args and cpp_args but Meson >= 0.48.0 doesn't override it anymore,
> maybe this was unsupported to begin with. It's too bad that Appveyor VS
> toolchain update in

> 
> https://gitlab.freedesktop.org/dbaker/mesa/commit/
> 6a39ee654abbb7c6de79ca138c5ac65108afe864
> 
> failed so bad leading a premature build failure otherwise the CRT mismatch
> error I see when LLVM is built with MT would have been replicated by Appveyor
> with a small difference, it would be a MD<->MTd mismatch instead of a MD<->MT.
> 
> I think fixing Appveyor failure from here
> 
> https://ci.appveyor.com/project/dcbaker/mesa/builds/19646797/job/
> 9maasfn20gh4ktcb
> 
> is as simple as
> 
> diff --git a/appveyor.yml b/appveyor.yml
> index c807905..84d48a7 100644
> --- a/appveyor.yml
> +++ b/appveyor.yml
> @@ -68,7 +68,7 @@ install:
>  - if "%BUILD_SYSTEM%"=="meson" set Path=C:\Python37-x64\Scripts;%Path%
>  - if "%BUILD_SYSTEM%"=="meson" meson --version
>  - if "%BUILD_SYSTEM%"=="meson" cinst -y pkgconfiglite
> -- if "%BUILD_SYSTEM%"=="meson" call "C:\Program Files (x86)\Microsoft Visual
> Studio 14.0\VC\vcvarsall.bat" x86
> +- if "%BUILD_SYSTEM%"=="meson" call "C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" x86
>  # Install flex/bison
>  - set WINFLEXBISON_ARCHIVE=win_flex_bison-%WINFLEXBISON_VERSION%.zip
>  - if not exist "%WINFLEXBISON_ARCHIVE%" appveyor DownloadFile "https://
> github.com/lexxmark/winflexbison/releases/download/v%WINFLEXBISON_VERSION%/
> %WINFLEXBISON_ARCHIVE%"

Yes, that looks correct. I'll update the branch with that. I'll also set the
--default_library=static to the appveyor build.

Thanks,
Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181031/aa28ed5f/attachment.sig>