[Mesa-dev] [PATCH] anv: Silence a couple compiler warnings

[Jason Ekstrand]

On Wed, Sep 12, 2018 at 6:54 PM Ian Romanick <idr at freedesktop.org> wrote:

> On 09/12/2018 03:03 PM, Jason Ekstrand wrote:
> > ---
> >  src/intel/vulkan/anv_device.c                    | 4 ++--
> >  src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 1 -
> >  2 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/intel/vulkan/anv_device.c
> b/src/intel/vulkan/anv_device.c
> > index 1af0eacb681..27fcab1ba9d 100644
> > --- a/src/intel/vulkan/anv_device.c
> > +++ b/src/intel/vulkan/anv_device.c
> > @@ -682,8 +682,8 @@ void anv_DestroyInstance(
> >        anv_physical_device_finish(&instance->physicalDevice);
> >     }
> >
> > -   vk_free(&instance->alloc, instance->app_info.app_name);
> > -   vk_free(&instance->alloc, instance->app_info.engine_name);
> > +   vk_free(&instance->alloc, (char *)instance->app_info.app_name);
> > +   vk_free(&instance->alloc, (char *)instance->app_info.engine_name);
>
> I'm assuming this is to remove the const decoration?  I usually put the
> warnings in the commit message.
>

Done.


> Assuming this is to remove const, this patch is
>

Yup, that's all.


> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>

Thanks!


> >
> >     VG(VALGRIND_DESTROY_MEMPOOL(instance));
> >
> > diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> > index 856101cc2ff..6868288e486 100644
> > --- a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> > +++ b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
> > @@ -516,7 +516,6 @@ anv_nir_apply_pipeline_layout(struct anv_pipeline
> *pipeline,
> >        }
> >     }
> >
> > -   unsigned image_uniform;
> >     if (map->image_count > 0) {
> >        assert(map->image_count <= MAX_IMAGES);
> >        assert(shader->num_uniforms == prog_data->nr_params * 4);
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180912/22edd63c/attachment.html>