[Mesa-dev] [PATCH 5/5] radv: fix setting global locations for indirect descriptors

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

for the series
On Wed, Sep 12, 2018 at 3:40 PM Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
> Indirect descriptors only need one entry, we don't have to
> emit a location for every descriptors.
>
> Fixes GPU hangs with new CTS:
> dEQP-VK.binding_model.descriptorset_random.*
>
> CC: 18.2 <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_nir_to_llvm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c
> index 84c8d2461c7..818229659d5 100644
> --- a/src/amd/vulkan/radv_nir_to_llvm.c
> +++ b/src/amd/vulkan/radv_nir_to_llvm.c
> @@ -811,7 +811,6 @@ set_global_input_locs(struct radv_shader_context *ctx, gl_shader_stage stage,
>                 for (unsigned i = 0; i < num_sets; ++i) {
>                         if ((ctx->shader_info->info.desc_set_used_mask & (1 << i)) &&
>                             ctx->options->layout->set[i].layout->shader_stages & stage_mask) {
> -                               set_loc_desc(ctx, i, user_sgpr_idx, true);
>                                 ctx->descriptor_sets[i] =
>                                         ac_build_load_to_sgpr(&ctx->ac,
>                                                               desc_sets,
> --
> 2.19.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev