[Mesa-dev] [PATCH] radv: fix use of unreachable() in the meta blit path

Timothy Arceri tarceri at itsqueeze.com
Mon Sep 17 09:22:21 UTC 2018


Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 17/9/18 7:18 pm, Samuel Pitoiset wrote:
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/amd/vulkan/radv_meta_blit.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_meta_blit.c b/src/amd/vulkan/radv_meta_blit.c
> index a205686e553..e7962911208 100644
> --- a/src/amd/vulkan/radv_meta_blit.c
> +++ b/src/amd/vulkan/radv_meta_blit.c
> @@ -384,7 +384,7 @@ meta_emit_blit(struct radv_cmd_buffer *cmd_buffer,
>   			pipeline = &device->meta_state.blit.pipeline_3d_src[fs_key];
>   			break;
>   		default:
> -			unreachable(!"bad VkImageType");
> +			unreachable("bad VkImageType");
>   		}
>   		break;
>   	}
> @@ -413,7 +413,7 @@ meta_emit_blit(struct radv_cmd_buffer *cmd_buffer,
>   			pipeline = &device->meta_state.blit.depth_only_3d_pipeline;
>   			break;
>   		default:
> -			unreachable(!"bad VkImageType");
> +			unreachable("bad VkImageType");
>   		}
>   		break;
>   	}
> @@ -442,12 +442,12 @@ meta_emit_blit(struct radv_cmd_buffer *cmd_buffer,
>   			pipeline = &device->meta_state.blit.stencil_only_3d_pipeline;
>   			break;
>   		default:
> -			unreachable(!"bad VkImageType");
> +			unreachable("bad VkImageType");
>   		}
>   		break;
>   	}
>   	default:
> -		unreachable(!"bad VkImageType");
> +		unreachable("bad VkImageType");
>   	}
>   
>   	if (!*pipeline) {
> 


More information about the mesa-dev mailing list