[Mesa-dev] [PATCH] radv: fix use of unreachable() in the meta blit path

Bas Nieuwenhuizen basni at chromium.org
Mon Sep 17 09:38:27 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
On Mon, Sep 17, 2018 at 11:18 AM Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_meta_blit.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_meta_blit.c b/src/amd/vulkan/radv_meta_blit.c
> index a205686e553..e7962911208 100644
> --- a/src/amd/vulkan/radv_meta_blit.c
> +++ b/src/amd/vulkan/radv_meta_blit.c
> @@ -384,7 +384,7 @@ meta_emit_blit(struct radv_cmd_buffer *cmd_buffer,
>                         pipeline = &device->meta_state.blit.pipeline_3d_src[fs_key];
>                         break;
>                 default:
> -                       unreachable(!"bad VkImageType");
> +                       unreachable("bad VkImageType");
>                 }
>                 break;
>         }
> @@ -413,7 +413,7 @@ meta_emit_blit(struct radv_cmd_buffer *cmd_buffer,
>                         pipeline = &device->meta_state.blit.depth_only_3d_pipeline;
>                         break;
>                 default:
> -                       unreachable(!"bad VkImageType");
> +                       unreachable("bad VkImageType");
>                 }
>                 break;
>         }
> @@ -442,12 +442,12 @@ meta_emit_blit(struct radv_cmd_buffer *cmd_buffer,
>                         pipeline = &device->meta_state.blit.stencil_only_3d_pipeline;
>                         break;
>                 default:
> -                       unreachable(!"bad VkImageType");
> +                       unreachable("bad VkImageType");
>                 }
>                 break;
>         }
>         default:
> -               unreachable(!"bad VkImageType");
> +               unreachable("bad VkImageType");
>         }
>
>         if (!*pipeline) {
> --
> 2.19.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list