[Mesa-dev] [PATCH] radv: Fix driver UUID SHA1 init.
dylan at pnwbakers.com
Thu Sep 20 18:48:41 UTC 2018
Quoting Bas Nieuwenhuizen (2018-09-20 11:35:35)
> On Thu, Sep 20, 2018 at 8:27 PM Dylan Baker <dylan at pnwbakers.com> wrote:
> > Quoting Bas Nieuwenhuizen (2018-09-20 11:16:44)
> > > On Thu, Sep 20, 2018 at 7:33 PM Eric Engestrom <eric.engestrom at intel.com> wrote:
> > > >
> > > > On Thursday, 2018-09-20 19:17:57 +0200, Bas Nieuwenhuizen wrote:
> > > > > Was missing the init, found by Emil.
> > > > >
> > > > > Fixes: d17443a4593 "radv: Use build ID if available for cache UUID."
> > > >
> > > > Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> > > >
> > > > > CC: <mesa-stable at lists.freedesktop.org>
> > > >
> > > > Cc'ing mesa-stable has no effect when you're already adding the
> > > > proper Fixes: tag :)
> > >
> > > Last time I asked about the difference between Fixes and CC, the
> > > conclusion I got that Fixes is only best effort for the stable
> > > branches and that if it does not apply it will be dropped silently,
> > > while for the CC ones the release manager will notify you.
> > That is not the way I treat fixes, I don't know what Juan and Andres do. I very
> > much *prefer* fixes tags. The scripts are much smarter about figuring out if
> > this patch is meant for my tree or not (ie, things with "cc: 18.2 <stable>" show
> > up in the list of patches for 18.1, but "Fixes: abcdef ("only in 18.2")" do not.
> > I can't speak for others, but I follow up on all patches that don't apply unless
> > they're reverted on master.
> After some digging, this is where I got that from:
> It would be great if we could be consistent about this. I'd be happy
> to do either (and typically do Fixes anyway if it is somewhat recent).
> btw one corner case I'd be interested to know if it gets picked with
> Fixes, is if it also works for patches that landed on the stable
> branch via cherrypick, i.e. does it detect it by the original hash?
Yes, it keeps a list of already picked commits and compares against that.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 228 bytes
More information about the mesa-dev