[Mesa-dev] [Mesa-stable] [PATCH] radv: Fix driver UUID SHA1 init.

[Juan A. Suarez Romero]

On Thu, 2018-09-20 at 20:16 +0200, Bas Nieuwenhuizen wrote:
> On Thu, Sep 20, 2018 at 7:33 PM Eric Engestrom <eric.engestrom at intel.com> wrote:
> > 
> > On Thursday, 2018-09-20 19:17:57 +0200, Bas Nieuwenhuizen wrote:
> > > Was missing the init, found by Emil.
> > > 
> > > Fixes: d17443a4593 "radv: Use build ID if available for cache UUID."
> > 
> > Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> > 
> > > CC: <mesa-stable at lists.freedesktop.org>
> > 
> > Cc'ing mesa-stable has no effect when you're already adding the
> > proper Fixes: tag :)
> 
> Last time I asked about the difference between Fixes and CC, the
> conclusion I got that Fixes is only best effort for the stable
> branches and that if it does not apply it will be dropped silently,
> while for the CC ones the release manager will notify you.
> 

In previous releases that was the way it worked: we always our best effort to
apply CC and Fixes patches. The difference was that if we couldn't apply the
patch, then we were only notifying in the pre-announcement "Rejected" section
about the CC, and silently ignoring the Fixes.


But nowadays, we notify about all the candidates to stable, which are CC and
Fixes.


> Given that this is a high priority fix for a regression introduced by
> a patch in the 18.2.1 release candidate, I think the extra CC is
> justified here.
> > 
> > > ---
> > >  src/amd/vulkan/radv_device.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> > > index 7e46a57fb57..31d9bb59637 100644
> > > --- a/src/amd/vulkan/radv_device.c
> > > +++ b/src/amd/vulkan/radv_device.c
> > > @@ -77,7 +77,9 @@ radv_device_get_cache_uuid(enum radeon_family family, void *uuid)
> > >       struct mesa_sha1 ctx;
> > >       unsigned char sha1[20];
> > >       unsigned ptr_size = sizeof(void*);
> > > +
> > >       memset(uuid, 0, VK_UUID_SIZE);
> > > +     _mesa_sha1_init(&ctx);
> > > 
> > >       if (!radv_get_build_id(radv_device_get_cache_uuid, &ctx) ||
> > >           !radv_get_build_id(LLVMInitializeAMDGPUTargetInfo, &ctx))
> > > --
> > > 2.19.0
> > > 
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable