[Mesa-dev] [PATCH v2 1/3] ac: add support for more types with struct/raw LLVM intrinsics

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Apr 16 14:44:37 UTC 2019


On 4/16/19 4:21 PM, Marek Olšák wrote:
> Reviewed-by: Marek Olšák <marek.olsak at amd.com 
> <mailto:marek.olsak at amd.com>>
Is the Rb for the whole series?
>
> Marek
>
> On Tue, Apr 16, 2019 at 2:27 AM Samuel Pitoiset 
> <samuel.pitoiset at gmail.com <mailto:samuel.pitoiset at gmail.com>> wrote:
>
>
>     On 4/15/19 11:07 PM, Marek Olšák wrote:
>>     On Mon, Apr 15, 2019 at 12:40 PM Samuel Pitoiset
>>     <samuel.pitoiset at gmail.com <mailto:samuel.pitoiset at gmail.com>> wrote:
>>
>>         LLVM 9+ now supports 8-bit and 16-bit types.
>>
>>         v2: - rebase on master (without the vec3 change)
>>
>>         Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com
>>         <mailto:samuel.pitoiset at gmail.com>>
>>         ---
>>          src/amd/common/ac_llvm_build.c | 46
>>         +++++++++++++++++++---------------
>>          1 file changed, 26 insertions(+), 20 deletions(-)
>>
>>         diff --git a/src/amd/common/ac_llvm_build.c
>>         b/src/amd/common/ac_llvm_build.c
>>         index 8f40ddda0b5..92dd4104592 100644
>>         --- a/src/amd/common/ac_llvm_build.c
>>         +++ b/src/amd/common/ac_llvm_build.c
>>         @@ -1135,6 +1135,7 @@
>>         ac_build_llvm8_buffer_store_common(struct ac_llvm_context *ctx,
>>                                            LLVMValueRef voffset,
>>                                            LLVMValueRef soffset,
>>                                            unsigned num_channels,
>>         +                                  LLVMTypeRef base_type,
>>
>>
>>     Can this be called return_channel_type?
>     Done locally.
>>
>>     Thanks,
>>     Marek
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190416/d2e8ceb4/attachment.html>


More information about the mesa-dev mailing list