[Mesa-dev] [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

Jose Fonseca jfonseca at vmware.com
Fri Aug 2 08:50:05 UTC 2019


Looks good to me.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

________________________________
From: Charmaine Lee <charmainel at vmware.com>
Sent: Thursday, August 1, 2019 23:56
To: mesa-dev at lists.freedesktop.org <mesa-dev at lists.freedesktop.org>; Brian Paul <brianp at vmware.com>; Neha Bhende <bhenden at vmware.com>; Roland Scheidegger <sroland at vmware.com>; Jose Fonseca <jfonseca at vmware.com>; airlied at redhat.com <airlied at redhat.com>
Cc: Charmaine Lee <charmainel at vmware.com>
Subject: [PATCH] gallivm: fix a missing argument to CreateAtomicCmpXchg

This patch fixes a missing argument to CreateAtomicCmpXchg for older
version of LLVM.
---
 src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
index 79d1029..8205d24 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
+++ b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
@@ -831,6 +831,7 @@ LLVMValueRef LLVMBuildAtomicCmpXchg(LLVMBuilderRef B, LLVMValueRef Ptr,
    /* LLVM 3.8 doesn't have a second ordering and uses old SynchronizationScope enum */
    return llvm::wrap(llvm::unwrap(B)->CreateAtomicCmpXchg(llvm::unwrap(Ptr), llvm::unwrap(Cmp),
                                                           llvm::unwrap(New), mapFromLLVMOrdering(SuccessOrdering),
+                                                          mapFromLLVMOrdering(FailureOrdering),
                                                           SingleThread ? llvm::SynchronizationScope::SingleThread : llvm::SynchronizationScope::CrossThread));
 }
 #endif
--
1.8.5.6

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190802/d737d44c/attachment.html>


More information about the mesa-dev mailing list