[Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

Boris Brezillon boris.brezillon at collabora.com
Tue Aug 27 10:40:08 UTC 2019


On Tue, 13 Aug 2019 15:30:20 -0700
Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:

> > I don't see any remove_ins()/insert_before() call in there. Do you see
> > any reason for using the _safe() variant here?  
> 
> Er, I think I meant the outer loop, which has a remove/insert pair at
> the bottom to change the current instruction.

Should I apply this patch or do you prefer to keep using the _safe()
variant even if it's not needed?


More information about the mesa-dev mailing list