[Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Tue Aug 27 14:25:03 UTC 2019


Assuming it passes CI, feel free to apply it :)

On Tue, Aug 27, 2019 at 12:40:08PM +0200, Boris Brezillon wrote:
> On Tue, 13 Aug 2019 15:30:20 -0700
> Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:
> 
> > > I don't see any remove_ins()/insert_before() call in there. Do you see
> > > any reason for using the _safe() variant here?  
> > 
> > Er, I think I meant the outer loop, which has a remove/insert pair at
> > the bottom to change the current instruction.
> 
> Should I apply this patch or do you prefer to keep using the _safe()
> variant even if it's not needed?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190827/d0d5a5f0/attachment.sig>


More information about the mesa-dev mailing list