[Mesa-dev] [PATCH 1/5] panfrost: Free the instruction object in mir_remove_instruction()

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Tue Aug 27 14:24:36 UTC 2019


Patches 1, 2, and 5 are:

	Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>

Patches 3 and 4 are modifying the guts of the scheduler which I plan to
rewrite in full, like, today.

On Tue, Aug 27, 2019 at 12:36:40PM +0200, Boris Brezillon wrote:
> To avoid memory leaks.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> ---
>  src/panfrost/midgard/compiler.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/panfrost/midgard/compiler.h b/src/panfrost/midgard/compiler.h
> index 099d108142b1..f9ba31b5959d 100644
> --- a/src/panfrost/midgard/compiler.h
> +++ b/src/panfrost/midgard/compiler.h
> @@ -315,6 +315,7 @@ static inline void
>  mir_remove_instruction(struct midgard_instruction *ins)
>  {
>          list_del(&ins->link);
> +        free(ins);
>  }
>  
>  static inline midgard_instruction*
> -- 
> 2.21.0
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190827/5b35a93a/attachment.sig>


More information about the mesa-dev mailing list