[Mesa-dev] [PATCH 1/5] panfrost: Free the instruction object in mir_remove_instruction()

[Boris Brezillon]

On Tue, 27 Aug 2019 07:24:36 -0700
Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:

> Patches 1, 2, and 5 are:
> 
> 	Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
> 
> Patches 3 and 4 are modifying the guts of the scheduler which I plan to
> rewrite in full, like, today.

No problem. I guess you can fix those problem as part of this
full-rewrite then ;-).

> 
> On Tue, Aug 27, 2019 at 12:36:40PM +0200, Boris Brezillon wrote:
> > To avoid memory leaks.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
> > ---
> >  src/panfrost/midgard/compiler.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/panfrost/midgard/compiler.h b/src/panfrost/midgard/compiler.h
> > index 099d108142b1..f9ba31b5959d 100644
> > --- a/src/panfrost/midgard/compiler.h
> > +++ b/src/panfrost/midgard/compiler.h
> > @@ -315,6 +315,7 @@ static inline void
> >  mir_remove_instruction(struct midgard_instruction *ins)
> >  {
> >          list_del(&ins->link);
> > +        free(ins);
> >  }
> >  
> >  static inline midgard_instruction*
> > -- 
> > 2.21.0
> >