[Mesa-dev] [PATCH 1/2] panfrost: Don't use mir_foreach_instr_in_block_safe() when not needed

[Boris Brezillon]

On Tue, 27 Aug 2019 07:25:03 -0700
Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:

> Assuming it passes CI, feel free to apply it :)

I guess that stands for a R-b :-).

> 
> On Tue, Aug 27, 2019 at 12:40:08PM +0200, Boris Brezillon wrote:
> > On Tue, 13 Aug 2019 15:30:20 -0700
> > Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> wrote:
> >   
> > > > I don't see any remove_ins()/insert_before() call in there. Do you see
> > > > any reason for using the _safe() variant here?    
> > > 
> > > Er, I think I meant the outer loop, which has a remove/insert pair at
> > > the bottom to change the current instruction.  
> > 
> > Should I apply this patch or do you prefer to keep using the _safe()
> > variant even if it's not needed?