[Mesa-dev] [Bug 111511] integer cube sampling fails to build shader

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 29 15:29:19 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=111511

--- Comment #1 from Roland Scheidegger <sroland at vmware.com> ---
I don't think averaging would be correct for integer cube corners (as integer
textures generally perform no lerp on values).
I think the problem here is the forcing of linear filtering paths for gather
ops (see beginning of lp_build_sample_soa_code() code) doesn't quite work here
- this is done because gather is nearly the same as linear filtering as far as
texel selection goes usually, just without the filter in general, so making the
code easier.
Perhaps the code needs to recognize the texture is integer and simply skip the
accurate_cube_corners code if the texture is integer (this should only happen
in the is_gather case in any case, since otherwise we should never end up in
the sample_image_linear path for integer textures).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190829/fa116afa/attachment.html>


More information about the mesa-dev mailing list