[Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

Alyssa Rosenzweig alyssa at rosenzweig.io
Tue Feb 5 00:25:20 UTC 2019


> Actually, I just gave you (Alyssa) push access... Also, as you'll (as
> far as I understand) basically be owning the panfrost bits in mesa,
> you should be able to commit to them.

Oh, thank you! :)

>  1. Don't break the build

Acked-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>

>  2. No merge commits

Just to be clear, is the idea to just make sure everything applies
cleanly / is a straightforward fast-forward, and if not, to rebase/squash
so it does?

>  4. Don't commit code outside of Panfrost without review from someone who
> has a decent claim to knowing what they're talking about in that area

Acked-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>

>  5. Be nice and give stake-holders (who may not be in your time zone)
> enough time to read their e-mail and review (at least 24 hours not
> including week-ends) before pushing anything.

Acked-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>

> Inside Panfrost, it's kind-of up to the Panfrost community developers what
> you want to do about review.  If you've got enough people, I highly
> recommend you do good code review.

Downstream, we've been trying to enforce proper reivew. I review other
people's code; I haggle people to review mine; you know how it is :)

Thank you again!

Alyssa


More information about the mesa-dev mailing list