[Mesa-dev] [PATCH 1/3] egl/android: Delete set_damage_region from egl dri vtbl

[Daniel Stone]

Hi,

On Fri, 20 Jul 2018 at 19:32, Eric Anholt <eric at anholt.net> wrote:
> Harish Krupo <harish.krupo.kps at intel.com> writes:
> > Thank you, understood it. I should have read the spec better :(.
> > Also, generalizing Android/deqp's usage seems to be wrong. Android's
> > deqp passed previously even when the driver wasn't restricting the
> > rendering to only the damaged regions.
> > Should I update these in the comments section of the extension?
>
> Yes, please.  If we're building an API, we should be documenting what it
> does.

I've resurrected this series in the form of a GitLab MR:
https://gitlab.freedesktop.org/wayland/weston/merge_requests/106

Looking at the original implementation, I think it was misguided: the
Intel driver hook replaced the scissor region in the context with the
extents of the damage region. Unless I've completely misread the spec,
the damage region should be additive to the scissor region, rather
than replacing it: it should also only apply to winsys buffers and not
user FBOs. Given that, I changed the DRI interface to target a
drawable rather than a context, as well as cleaned it up, renamed it,
added substantial documentation, and a Gallium + VC4 implementation.

The MR is tagged WIP because I still have a lot of outstanding
questions on how the implementation should look.

Cheers,
Daniel