[Mesa-dev] [PATCH 0/2] spirv/nir: fix pixel_center_integer/origin_upper_left (two different solutions)

Alejandro PiƱeiro apinheiro at igalia.com
Fri Feb 8 14:33:12 UTC 2019

Note that the two patches are independent. Are two possible solutions
for the same problem. Details below.

As mentioned on the following MR:

changing the order of how ExecutionModes are handled affected handling
OriginUpperLeft and PixelCenterInteger. On such MR, I proposed a
straighforward walking through the inputs after the execution modes
were handled. Jason said that solution was ok, but also mentioned that
an alternative would be move that info from nir_variable_data to

So this series has those two solutions implemented, so we can choose
what we prefer. The first one is a smaller change, that only affects
spirv_to_nir. The second is bigger, but at the same time is somewhat a
cleaning, because pixel_center_integer was already on shader_info.fs,
so right now we have duplicated data.

Although I'm waiting for Intel CI to confirm that there are no
regressions, both patches fixes the tests that highlighted the


More information about the mesa-dev mailing list