[Mesa-dev] [Bug 109596] Crashes on glXBindTexImageEXT call on surface whose Window got destroyed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109596

            Bug ID: 109596
           Summary: Crashes on glXBindTexImageEXT call on surface whose
                    Window got destroyed
           Product: Mesa
           Version: 18.3
          Hardware: Other
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/swrast
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: samuel.thibault at ens-lyon.org
        QA Contact: mesa-dev at lists.freedesktop.org

Created attachment 143345
  --> https://bugs.freedesktop.org/attachment.cgi?id=143345&action=edit
proposed fix

Hello,

As reported on

https://gitlab.com/compiz/compiz-core/issues/141

compiz is getting crashes during a glXBindTexImageEXT call about a window
getting unmapped. This happens in the swraster. I traced it into
swrastGetDrawableInfo(), whose XGetGeometry call fails because the window is no
more. The attached patch avoids the issue, I tend to think that at the very
least an assert should be used to avoid leaking uninitialized values, but
returning an empty geometry would avoid a crash in such case, the caller just
has to be able to cope with it.

If this (calling glXBindTexImageEXT on a drawable whose Window is no more) is
considered to be an issue in the application, please answer to
https://gitlab.com/compiz/compiz-core/issues/141

Samuel

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190209/4a14c6f0/attachment.html>