[Mesa-dev] [PATCH 1/3] panfrost: Fix various leaks unmapping resources

Alyssa Rosenzweig alyssa at rosenzweig.io
Fri Feb 15 21:42:10 UTC 2019

> Nit: staying consistent with "foo != NULL" vs "foo" checks helps a
> lot.

Which form is preferred?

> free(NULL); is perfectly valid.

Huh, TIL, thank you.

> The function pointer seems to be NULL. Did you forget to git add the
> file which sets it?

See my comment in the other mail about the overlay. Generally, functions
of the form "screen->driver->..." are specific to the kernel module in
question, and we're not able to upstream the code specific to the vendor
kernel for various reasons. It may be a good idea to stub out the
corresponding routines in pan_drm.c, but that's up to Rob and Tomeu.

More information about the mesa-dev mailing list