[Mesa-dev] [PATCH 1/3] panfrost: Fix various leaks unmapping resources

Emil Velikov emil.l.velikov at gmail.com
Tue Feb 19 13:12:38 UTC 2019

On Fri, 15 Feb 2019 at 21:42, Alyssa Rosenzweig <alyssa at rosenzweig.io> wrote:
> > Nit: staying consistent with "foo != NULL" vs "foo" checks helps a
> > lot.
> Which form is preferred?
I think that varies across parts of mesa. I'd pick one and use it
through panfrost.

> > free(NULL); is perfectly valid.
> Huh, TIL, thank you.
> > The function pointer seems to be NULL. Did you forget to git add the
> > file which sets it?
> See my comment in the other mail about the overlay. Generally, functions
> of the form "screen->driver->..." are specific to the kernel module in
> question, and we're not able to upstream the code specific to the vendor
> kernel for various reasons. It may be a good idea to stub out the
> corresponding routines in pan_drm.c, but that's up to Rob and Tomeu.

Are there any legal reasons? Alternatively, I think it's reasonable to
have the code merged.
Sure it may not be perfect yet it's something people can grab and
start hacking with.

Plus, as in this example the fix cannot be easily verified :-(


More information about the mesa-dev mailing list