[Mesa-dev] [Bug 109752] meson: more ensure that xmlpool_options.h is generated for targets that need it

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Feb 24 11:15:35 UTC 2019


Eric Engestrom <fdo-bugs at engestrom.ch> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Eric Engestrom <fdo-bugs at engestrom.ch> ---
Hi David!

Thanks for your patch! I verified it and you are entirely correct :)

The preferred way to send patches for Mesa is by submitting a merge request
(https://gitlab.freedesktop.org/mesa/mesa/merge_requests, see

I just saw that you attached your patch, which I missed earlier, and I couldn't
manage to fixup the copy/pasted patch, so I rewrote it, added a few `Fixes:`
tags so that it gets picked up for backports, and pushed it as:

commit 6fa923a65daf1ee73c5cc763ade91abc82da7085
Author: David Shao <davshao at gmail.com>
Date:   Sun, 24 Feb 2019 09:00:36 +0000

    meson: ensure that xmlpool_options.h is generated for gallium targets that
need it

    Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker"
    Fixes: 22a817af8a89eb3c762f "meson: build gallium xvmc state tracker"
    Fixes: 5a785d51a6d68ec676ce "meson: build gallium va state tracker"
    Fixes: 0ba909f0f111824223bc "meson: build gallium xa state tracker"
    Fixes: 1d36dc674d528b93bec3 "meson: build gallium omx state tracker"
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

Please double check the commit to make sure I didn't miss something :)

Thanks again for your patch, and welcome to Mesa!

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190224/a8a2f38f/attachment.html>

More information about the mesa-dev mailing list