[Mesa-dev] [PATCH v10 12/20] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

[Pierre Moreau]

> thanks! Just FYI, our meson build uses - in option names, not _. And, I'd prefer
> just "opencl-spirv".

Err right, I meant with '-' in the option name.  I am fine with "opencl-spirv";
I was initially going with "gallium-opencl-spirv" since the other
clover-related command was named "gallium-opencl".


> When I make the command line "gallium-opencl", we (Intel)
> were still firmly in the not gallium world, now that we have iris and are moving
> toward gallium I'm not sure I made the right decision :/

Easy: Intel can just drop all of its OpenCL drivers and embrace clover as the
true one, that way everything is in the gallium word and there aren’t any
confusions. :-D


By the way, you made me spot an error in the root meson.build file:
```with_opencl_icd = _opencl == 'icd'```
and a bit further down
```with_gallium_icd = false```
I guess you were still hesitating on how to name it? ;-)
I’ll send a separate patch to fix this.

Pierre
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190109/19ae0c81/attachment.sig>