[Mesa-dev] [PATCH] meson: Fix with_gallium_icd to with_opencl_icd

Dylan Baker dylan at pnwbakers.com
Wed Jan 9 22:17:17 UTC 2019


Quoting Pierre Moreau (2019-01-09 14:03:45)
> `with_gallium_icd` is never used throughout the different Meson build
> files, whereas `with_opencl_icd` tracks whether or not `gallium-opencl`
> was set to "icd".
> 
> Signed-off-by: Pierre Moreau <pierre.morrow at free.fr>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 601085e0552..e759bbf96a5 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -668,7 +668,7 @@ if _opencl != 'disabled'
>  else
>    dep_clc = null_dep
>    with_gallium_opencl = false
> -  with_gallium_icd = false
> +  with_opencl_icd = false
>  endif
>  
>  gl_pkgconfig_c_flags = []
> -- 
> 2.20.1
> 

please add:

Fixes: 42ea0631f108d82554339530d6c88aa1b448af1e
       ("meson: build clover")
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

I'll add these and push this later unless anyone else objects or beats me to
it :)

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190109/4e871413/attachment.sig>


More information about the mesa-dev mailing list