[Mesa-dev] Thoughts after hitting 100 merge requests?

Matt Turner mattst88 at gmail.com
Tue Jan 15 23:47:12 UTC 2019


On Mon, Jan 14, 2019 at 4:36 AM Daniel Stone <daniel at fooishbar.org> wrote:
>
> Hi,
>
> On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand <jason at jlekstrand.net> wrote:
> >  5. There's no way with gitlab for Reviewed-by tags to get automatically applied as part of the merging process.  This makes merging a bit more manual than it needs to be but is really no worse than it was before.
>
> I'm still on the side of not seeing the value in them.

Reviewed-by tags are useful for measuring the quantity of patch review
people do (which is useful in a corporate environment...). It's often
a thankless task that's valued much lower than first order
contributions, so having a way to at least quantify patch reviews
shows that people are spending their time to help others contribute.

The number of R-b tags is not a 100% accurate picture of the
situation, but it gives at least a good overview of who is doing the
tedious work of patch review. For instance, in 2018 the top reviewers
are

    620 Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    530 Marek Olšák <marek.olsak at amd.com>
    505 Jason Ekstrand <jason.ekstrand at intel.com>
    452 Kenneth Graunke <kenneth at whitecape.org>

If my name were in there, it would definitely be something I put on my
yearly review.


More information about the mesa-dev mailing list