[Mesa-dev] Thoughts after hitting 100 merge requests?

[Daniel Stone]

Hi,

On Tue, 15 Jan 2019 at 23:47, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Jan 14, 2019 at 4:36 AM Daniel Stone <daniel at fooishbar.org> wrote:
> > On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > >  5. There's no way with gitlab for Reviewed-by tags to get automatically applied as part of the merging process.  This makes merging a bit more manual than it needs to be but is really no worse than it was before.
> >
> > I'm still on the side of not seeing the value in them.
>
> Reviewed-by tags are useful for measuring the quantity of patch review
> people do (which is useful in a corporate environment...). It's often
> a thankless task that's valued much lower than first order
> contributions, so having a way to at least quantify patch reviews
> shows that people are spending their time to help others contribute.
>
> The number of R-b tags is not a 100% accurate picture of the
> situation, but it gives at least a good overview of who is doing the
> tedious work of patch review. For instance, in 2018 the top reviewers
> are
>
>     620 Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>     530 Marek Olšák <marek.olsak at amd.com>
>     505 Jason Ekstrand <jason.ekstrand at intel.com>
>     452 Kenneth Graunke <kenneth at whitecape.org>
>
> If my name were in there, it would definitely be something I put on my
> yearly review.

Obviously shell scripting will not do in the advanced enterprise
environment, so we're into the realm of Python. Nevertheless, I've
attached a script which will let you prove your individual worth to
the company, as well as producing a leaderboard for team morale
purposes:

~/tmp % ./kwg-gitlab-rb.py
kwg participated in 10 merged MRs this year (61 total):
    MR  105: gallium: Add a PIPE_CAP_QUERY_PIPELINE_STATISTICS_SINGLE
capability and query type
    MR   96: st/mesa: Optionally override RGB/RGBX dst alpha blend factors
    MR   95: st/nir: Lower TES gl_PatchVerticesIn to a constant if
linked with a TCS.
    MR   92: nir: Allow a non-existent sampler deref in
nir_lower_samplers_as_deref
    MR   62: i965: fix VF cache issue workaround
    MR   39: i965: Enable software support for
ARB_gpu_shader_fp64/ARB_gpu_shader_int64
    MR   26: Revert "nir/lower_indirect: Bail early if modes == 0"
    MR   12: Add preemption support to i965 on gen9+
    MR    9: Misc optimizations
    MR    4: mesa/st: Expose compute shaders when NIR support is advertised.

Top 10 MR participants:
     29 jekstrand
     16 anholt
     14 bnieuwenhuizen
     10 jljusten
     10 kwg
     10 idr
      9 dbaker
      9 eric
      8 llandwerlin
      6 cmarcelo

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwg-gitlab-rb.py
Type: text/x-python
Size: 1346 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190116/93c35751/attachment.py>