[Mesa-dev] [PATCH 1/8] i965: Removed assertions from intel_miptree_map_etc

[Nanley Chery]

On Mon, Nov 19, 2018 at 10:54:05AM +0200, Eleni Maria Stea wrote:
> The assertions that the GL_MAP_WRITE_BIT and GL_MAP_INVALIDATE_RANGE_BIT
> in intel_miptree_map_etc should be removed since they will fail when the
  ^
  missing "bits are set"?

> ETC miptree is mapped for reading.
> 

The assertion is still valid at this point. Reading will give you
incorrect results. You'll want to do this later on in the series though.

> Fixes: KHR-GL45.direct_state_access.textures_compressed_subimage crash
       ^
       Should probably remove the semicolon so that you're not using the
       Fixes tag. I think that's reserved for fixing bugs in 
       commits. See the git log for more info.

-Nanley

> on Gen 7 GPUs.
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index 8e50aabb3b..5e11ec0c30 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -3444,9 +3444,6 @@ intel_miptree_map_etc(struct brw_context *brw,
>        assert(mt->format == MESA_FORMAT_R8G8B8X8_UNORM);
>     }
>  
> -   assert(map->mode & GL_MAP_WRITE_BIT);
> -   assert(map->mode & GL_MAP_INVALIDATE_RANGE_BIT);
> -
>     intel_miptree_access_raw(brw, mt, level, slice, true);
>  
>     map->stride = _mesa_format_row_stride(mt->etc_format, map->w);
> -- 
> 2.19.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev