[Mesa-dev] [PATCH] mesa: GLES2 fix for OES float/half-float textures.

[Erik Faye-Lund]

On Mon, 2019-01-28 at 09:22 -0800, Eric Anholt wrote:
> Erik Faye-Lund <erik.faye-lund at collabora.com> writes:
> 
> > On Fri, 2019-01-25 at 13:41 -0800, Eric Anholt wrote:
> > > Nick Kreeger <nick.kreeger at gmail.com> writes:
> > > 
> > > > The OES_texture* extensions for float and half-float are valid
> > > > when
> > > > GLES2 is present w/ the matching
> > > > OES_texture_float/OES_texture_half_float extensions. This fix
> > > > ensures
> > > > that these formats are valid for this configuration.
> > > 
> > > I don't see OES_texture_float.txt specifying these tokens as
> > > additions
> > > to the list of valid base internal formats (table 3.8 of the
> > > GLES2
> > > spec), so I think this change is invalid.  Sized internalformats
> > > were
> > > introduced with GLES3.
> > > 
> > 
> > Hmm, seems you're right. I suppose this should be reverted? Nick,
> > what
> > do you think?
> 
> I don't see it in the tree, though.

Right. I now feel a bit embaressed for my poor memory :P

Seems I noticed this in the discussion for the v3 of the patch, which
lead to it being dropped:

https://lists.freedesktop.org/archives/mesa-dev/2018-December/211819.html