[Mesa-dev] [PATCH] radv/gfx10: don't set array pitch field on images

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Jul 16 00:11:57 UTC 2019


r-b

On Tue, Jul 16, 2019 at 1:25 AM Dave Airlie <airlied at gmail.com> wrote:
>
> From: Dave Airlie <airlied at redhat.com>
>
> Setting this seems to be broken, amdvlk only sets it for quilted
> textures which I'm not sure what those are.
>
> Fixes: dEQP-VK.glsl.texture_functions.query.texturesize*3d*
> ---
>  src/amd/vulkan/radv_image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index ccbec36849e..66a948fde4a 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -682,7 +682,7 @@ gfx10_make_texture_descriptor(struct radv_device *device,
>          */
>         state[4] = S_00A010_DEPTH(type == V_008F1C_SQ_RSRC_IMG_3D ? depth - 1 : last_layer) |
>                    S_00A010_BASE_ARRAY(first_layer);
> -       state[5] = S_00A014_ARRAY_PITCH(!!(type == V_008F1C_SQ_RSRC_IMG_3D)) |
> +       state[5] = S_00A014_ARRAY_PITCH(0) |
>                    S_00A014_MAX_MIP(image->info.samples > 1 ?
>                                     util_logbase2(image->info.samples) :
>                                     image->info.levels - 1) |
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list