[Mesa-dev] [PATCH 5/5] radv/gfx10: enable VK_EXT_transform_feedback

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Jul 23 19:32:03 UTC 2019


r-b for the series if you resolve my comment on patch  4.

On Tue, Jul 23, 2019 at 3:21 PM Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
> When a pipeline uses transform feedback, the driver fallbacks to
> the legacy path because NGG support for streamout is a non-trivial
> amount of work.
>
> AMDVLK also uses the legacy path for streamout, while RadeonSI
> uses the new NGG path.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_extensions.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
> index e9addad0035..8e1d61dfaaf 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -129,7 +129,7 @@ EXTENSIONS = [
>      Extension('VK_EXT_shader_stencil_export',             1, True),
>      Extension('VK_EXT_shader_subgroup_ballot',            1, True),
>      Extension('VK_EXT_shader_subgroup_vote',              1, True),
> -    Extension('VK_EXT_transform_feedback',                1, 'device->rad_info.chip_class < GFX10'),
> +    Extension('VK_EXT_transform_feedback',                1, True),
>      Extension('VK_EXT_vertex_attribute_divisor',          3, True),
>      Extension('VK_EXT_ycbcr_image_arrays',                1, True),
>      Extension('VK_AMD_buffer_marker',                     1, True),
> --
> 2.22.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list