[Mesa-dev] [Bug 110810] Vulkan spec break: VkCommandBufferInheritanceInfo.framebuffer is NOT optional

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110810

--- Comment #2 from Tapani Pälli <lemody at gmail.com> ---
AFAICT anv is handling this correctly. Anv in 18.2.8 has a bug which has been
fixed later (Mesa 19) with following commit:

--- 8< ---
commit 1ad26f941792f07f226c054811be78b0c0ac9fce
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Tue Feb 12 19:19:13 2019 +0100

    anv/cmd_buffer: check for NULL framebuffer

    This can happen when we record a VkCmdDraw in a secondary buffer that
    was created inheriting from the primary buffer, but with the framebuffer
    set to NULL in the VkCommandBufferInheritanceInfo.

    Vulkan 1.1.81 spec says that "the application must ensure (using scissor
    if neccesary) that all rendering is contained in the render area [...]
    [which] must be contained within the framebuffer dimesions".

    While this should be done by the application, commit 465e5a86 added the
    clamp to the framebuffer size, in case of application does not do it.
    But this requires to know the framebuffer dimensions.

    If we do not have a framebuffer at that moment, the best compromise we
    can do is to just apply the scissor as it is, and let the application to
    ensure the rendering is contained in the render area.

    v2: do not clamp to framebuffer if there isn't a framebuffer

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190603/b24d8b8f/attachment-0001.html>