[Mesa-dev] [PATCH 2/2] panfrost: ci: Avoid pulling Docker image on every run

[Tomeu Vizoso]

On 6/6/19 6:10 PM, Michel Dänzer wrote:
> On 2019-05-20 11:33 a.m., Tomeu Vizoso wrote:
>> Jump over the container stage if we haven't changed any of the files
>> that involved in building the container images.
>>
>> This saves 1-2 minutes in each run and helps conserve resources.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
>> ---
>>   src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 52 +++++++++++--------
>>   1 file changed, 29 insertions(+), 23 deletions(-)
>>
>> diff --git a/src/gallium/drivers/panfrost/ci/gitlab-ci.yml b/src/gallium/drivers/panfrost/ci/gitlab-ci.yml
>> index 635d7b04bcde..3491b9f98752 100644
>> --- a/src/gallium/drivers/panfrost/ci/gitlab-ci.yml
>> +++ b/src/gallium/drivers/panfrost/ci/gitlab-ci.yml
>> @@ -2,23 +2,29 @@ variables:
>>     DOCKER_DRIVER: overlay2
>>   
>>   stages:
>> -  - build-container
>> +  - containers
>>     - build
>>     - test
>>   
>>   # Build Docker image with deqp, the rootfs and the build deps for Mesa
>> -.build-container:
>> -  stage: build-container
>> -  when: always
>> +.container:
>> +  stage: containers
>> +  image: docker:stable
>> +  only:
>> +    changes:
>> +      - src/gallium/drivers/panfrost/ci/gitlab-ci.yml
>> +      - src/gallium/drivers/panfrost/ci/Dockerfile
>> +      - src/gallium/drivers/panfrost/ci/create-rootfs.sh
>> +      - src/gallium/drivers/panfrost/ci/${KERNEL_ARCH}.config
> 
> FYI, this might break under some circumstances; see
> https://gitlab.freedesktop.org/xorg/xserver/commit/0ec9a13c2a207e98e2dd6b352552c0e069af0727
> .
> 
> 
> See the top-level .gitlab-ci.yml file for a well-tested way to only
> generate a docker image when needed, based on a fixed image tag.

It also looks much cleaner, will see what else I can steal.

Thanks!

Tomeu