[Mesa-dev] [PATCH v2 8/9] radv: pass sample locations for transitions before depth/stencil resolves

[Samuel Pitoiset]

HTILE decompressions need the user sample locations if specified
in the current subpass.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_cmd_buffer.c   |  2 +-
 src/amd/vulkan/radv_meta_resolve.c | 30 ++++++++++++++++++++++++++++++
 src/amd/vulkan/radv_private.h      |  3 +++
 3 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index d69bec60bb8..b08e5829723 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2644,7 +2644,7 @@ void radv_subpass_barrier(struct radv_cmd_buffer *cmd_buffer,
 	                                                      NULL);
 }
 
-static uint32_t
+uint32_t
 radv_get_subpass_id(struct radv_cmd_buffer *cmd_buffer)
 {
 	struct radv_cmd_state *state = &cmd_buffer->state;
diff --git a/src/amd/vulkan/radv_meta_resolve.c b/src/amd/vulkan/radv_meta_resolve.c
index 48ebbd1fc10..ea1b3a6781c 100644
--- a/src/amd/vulkan/radv_meta_resolve.c
+++ b/src/amd/vulkan/radv_meta_resolve.c
@@ -802,6 +802,20 @@ radv_decompress_resolve_subpass_src(struct radv_cmd_buffer *cmd_buffer)
 	}
 }
 
+static struct radv_sample_locations_state *
+radv_get_resolve_sample_locations(struct radv_cmd_buffer *cmd_buffer)
+{
+	struct radv_cmd_state *state = &cmd_buffer->state;
+	uint32_t subpass_id = radv_get_subpass_id(cmd_buffer);
+
+	for (uint32_t i = 0; i < state->num_subpass_sample_locs; i++) {
+		if (state->subpass_sample_locs[i].subpass_idx == subpass_id)
+			return &state->subpass_sample_locs[i].sample_location;
+	}
+
+	return NULL;
+}
+
 /**
  * Decompress CMask/FMask before resolving a multisampled source image.
  */
@@ -832,6 +846,22 @@ radv_decompress_resolve_src(struct radv_cmd_buffer *cmd_buffer,
 			.layerCount = region->srcSubresource.layerCount,
 		};
 
+		if (src_image->flags & VK_IMAGE_CREATE_SAMPLE_LOCATIONS_COMPATIBLE_DEPTH_BIT_EXT) {
+			/* If the depth/stencil image uses different sample
+			 * locations, we need them during HTILE decompressions.
+			 */
+			struct radv_sample_locations_state *sample_locs =
+				radv_get_resolve_sample_locations(cmd_buffer);
+
+			barrier.pNext = &(VkSampleLocationsInfoEXT) {
+				.sType = VK_STRUCTURE_TYPE_SAMPLE_LOCATIONS_INFO_EXT,
+				.sampleLocationsPerPixel = sample_locs->per_pixel,
+				.sampleLocationGridSize = sample_locs->grid_size,
+				.sampleLocationsCount = sample_locs->count,
+				.pSampleLocations = sample_locs->locations,
+			};
+		}
+
 		radv_CmdPipelineBarrier(radv_cmd_buffer_to_handle(cmd_buffer),
 					VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT,
 					VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT,
diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h
index 5c42f4f418a..3133c44f79d 100644
--- a/src/amd/vulkan/radv_private.h
+++ b/src/amd/vulkan/radv_private.h
@@ -1959,6 +1959,9 @@ struct radv_subpass {
 	VkSampleCountFlagBits                        max_sample_count;
 };
 
+uint32_t
+radv_get_subpass_id(struct radv_cmd_buffer *cmd_buffer);
+
 struct radv_render_pass_attachment {
 	VkFormat                                     format;
 	uint32_t                                     samples;
-- 
2.22.0