[Mesa-dev] [PATCH 3/6] panfrost: Control texop value earlier

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Mon Jun 17 14:09:16 UTC 2019

> No problem, I'll rebase once this work has landed.

I thought it has?

> Hm, the list of allowed ops is likely to differ (doesn't make sense to
> allow txs instructions when building a midgard tex instruction) so I'm
> not sure it's a good idea to share this switch statement.

Well, I was maybe more suggesting the switch statement up there would
return NULL/false/-1/whatever for a NIR op not representable by a
(single) Midgard tex instruction. So we call for the op at the
beginning, and based on the results choose between two different
funciton calls (one for a Midgard tex op, one for special handling).

Not sure, just wondering :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190617/de2fc332/attachment.sig>

More information about the mesa-dev mailing list