[Mesa-dev] [Mesa-stable] [PATCH] radv: make sure to init the DCC decompress compute path state

[Juan A. Suarez Romero]

On Tue, 2019-06-18 at 12:12 +0200, Samuel Pitoiset wrote:
> On 6/18/19 12:05 PM, Juan A. Suarez Romero wrote:
> > On Thu, 2019-06-13 at 12:44 +0200, Samuel Pitoiset wrote:
> > > This fixes a segfault when forcing DCC decompressions on compute
> > > because internal meta objects are not created since the on-demand
> > > stuff.
> > > 
> > Does it make sense to nominate this to stable?
> No, that's useless.


Thanks for the feedback!

	J.A.

> > 	J.A.
> > 
> > > Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> > > ---
> > >   src/amd/vulkan/radv_meta_fast_clear.c | 8 ++++++++
> > >   1 file changed, 8 insertions(+)
> > > 
> > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c
> > > index 8f97c1a8f15..176f9803b45 100644
> > > --- a/src/amd/vulkan/radv_meta_fast_clear.c
> > > +++ b/src/amd/vulkan/radv_meta_fast_clear.c
> > > @@ -753,6 +753,14 @@ radv_decompress_dcc_compute(struct radv_cmd_buffer *cmd_buffer,
> > >   	state->flush_bits |= RADV_CMD_FLAG_FLUSH_AND_INV_CB |
> > >   			     RADV_CMD_FLAG_FLUSH_AND_INV_CB_META;
> > >   
> > > +	if (!cmd_buffer->device->meta_state.fast_clear_flush.cmask_eliminate_pipeline) {
> > > +		VkResult ret = radv_device_init_meta_fast_clear_flush_state_internal(cmd_buffer->device);
> > > +		if (ret != VK_SUCCESS) {
> > > +			cmd_buffer->record_result = ret;
> > > +			return;
> > > +		}
> > > +	}
> > > +
> > >   	radv_meta_save(&saved_state, cmd_buffer, RADV_META_SAVE_DESCRIPTORS |
> > >   	                                         RADV_META_SAVE_COMPUTE_PIPELINE);
> > >   
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable